Let block terminators claim the preceding newline for consistency#9925
Draft
pmario wants to merge 1 commit into
Draft
Let block terminators claim the preceding newline for consistency#9925pmario wants to merge 1 commit into
pmario wants to merge 1 commit into
Conversation
Consistency fix: every block terminator now claims the newline before its closing marker, so paragraph text is identical with and without a blank line, and quoteblock, styleblock, html and conditional behave like codeblock, typedblock and macrodef. Fixes TiddlyWiki#9907. * Anchor the quoteblock and styleblock terminators from the newline * Prefix the html and conditional terminators with an optional newline; a mandatory anchor would break legal mid-line close tags * Leave inline paths unchanged: a newline in an inline run is real content * Correct the (:?^| typo to (?:^| in the fnprocdef end marker regexp Compatibility: these paragraph text nodes no longer end with an invisible newline and their end positions shift. Rendered output is unchanged; practical risk is low.
✅ Deploy Preview for tiddlywiki-previews ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Confirmed: pmario has already signed the Contributor License Agreement (see contributing.md) |
📊 Build Size Comparison:
|
| Branch | Size |
|---|---|
| Base (master) | 2492.6 KB |
| PR | 2493.3 KB |
Diff: ⬆️ Increase: +0.8 KB
✅ Change Note Status
All change notes are properly formatted and validated!
📝 $:/changenotes/5.5.0/#9907
Type: bugfix | Category: developer
Release: 5.5.0
Paragraph text before a block closing marker no longer carries a trailing newline
🔗 #9907
👥 Contributors: pmario
⚠️ Impact: $:/changenotes/5.5.0/#9907/impacts/text-end-positions
Impact Type: compatibility-break
Related Change: $:/changenotes/5.5.0/#9907
Text and end positions of paragraph nodes before block terminators have changed
📖 Change Note Guidelines
Change notes help track and communicate changes effectively. See the full documentation for details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consistency fix: every block terminator now claims the newline before its closing marker, so paragraph text is identical with and without a blank line, and quoteblock, styleblock, html and conditional behave like codeblock, typedblock and macrodef.
Compatibility: these paragraph text nodes no longer end with an invisible newline and their end positions shift. Rendered output is unchanged; practical risk is low.
Part of #9908.